The Daily WTF
Andy C writes:
One of our colleagues dug this code up from an outsourced project. Took a few us to try to find out what it actually does, we’re still not completely sure.
This is the associated Java code:
if (productList != null && !productList.isEmpty()) { for (int i = 0; i < productList.size(); i++) { String currentProductID = String.valueOf(productList.get(i).getProductId()); String toMatchProductID = String.valueOf(currentProductID); if (currentProductID.equals(toMatchProductID)) { productName = productList.get(i).getProductName(); break; } } }
If you just skim over the code, something you might do if you were just going through a large codebase, it looks like a reasonable “search” method. Find the object with the matching ID. But that’s only on a skim. If you actually read the code, well…
First, we start with a check- make sure we actually have a productList. The null check is reasonable (I’ll assume this predates Java’s Optional type), but
To read the full article click on the 'post' link at the top.