CodeSOD: In House Refactoring

This post was originally published on this site

The Daily WTF

Today’s submitter works for a company that has a history of outsourcing pretty much all development, and to the lowest bidder, at that. This resulted in some terrible code, complete with 30,000 line classes, so the company decided to bring development back in house and clean up the code.

After three years of hard work, the in-house team was proud to announce their new, more maintainable, version of the code. Unfortunately, they didn’t have the best sense of what maintainable looked like, so their Java code had methods with signatures like this:

public String createNewActivity( String node_id, String problem_id, String act_spec, String act_reason, String eff_date, String person_id, String synopsis, String commit_date, int elapsed_time, String comment, boolean customer_viewable, String actionPlan, String apFolderLocation, String apLogging, String areasAffected, String artifactLocation, String assembliesFileChanged, Date assignmentDate, String baseResults, String baseVersionRecreated, Date completionDate, String coordinator, String crystalReportsFiles, String customerBusinessImpact, String customerName, String customization, String custFolderResults, String

To read the full article click on the 'post' link at the top.